]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
NFSD: Clear SECLABEL in the suppattr_exclcreat bitmap
authorChuck Lever <chuck.lever@oracle.com>
Mon, 17 Nov 2025 16:00:49 +0000 (11:00 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Thu, 18 Dec 2025 16:18:39 +0000 (11:18 -0500)
commit27d17641cacfedd816789b75d342430f6b912bd2
treed7734db783c0366c491e461e0c2ac99bff5a185d
parentdf8d829bba3adcf3cc744c01d933b6fd7cf06e91
NFSD: Clear SECLABEL in the suppattr_exclcreat bitmap

>From RFC 8881:

5.8.1.14. Attribute 75: suppattr_exclcreat

> The bit vector that would set all REQUIRED and RECOMMENDED
> attributes that are supported by the EXCLUSIVE4_1 method of file
> creation via the OPEN operation. The scope of this attribute
> applies to all objects with a matching fsid.

There's nothing in RFC 8881 that states that suppattr_exclcreat is
or is not allowed to contain bits for attributes that are clear in
the reported supported_attrs bitmask. But it doesn't make sense for
an NFS server to indicate that it /doesn't/ implement an attribute,
but then also indicate that clients /are/ allowed to set that
attribute using OPEN(create) with EXCLUSIVE4_1.

Ensure that the SECURITY_LABEL and ACL bits are not set in the
suppattr_exclcreat bitmask when they are also not set in the
supported_attrs bitmask.

Fixes: 8c18f2052e75 ("nfsd41: SUPPATTR_EXCLCREAT attribute")
Cc: stable@vger.kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c