]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/armada: Fix off-by-one error in armada_overlay_get_property()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 17 Jul 2023 13:25:40 +0000 (15:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:22:38 +0000 (12:22 +0200)
commit27eee65b2e31855b242c0e887c2e39f1c8bea073
tree83229974c579ff5161b2377e0f75a9c9ff2a033e
parentcc9254b24a4b70f064b0eebd2774d342ad199a01
drm/armada: Fix off-by-one error in armada_overlay_get_property()

[ Upstream commit 5f0d984053f74983a287100a9519b2fabb785fb5 ]

As ffs() returns one more than the index of the first bit set (zero
means no bits set), the color key mode value is shifted one position too
much.

Fix this by using FIELD_GET() instead.

Fixes: c96103b6c49ff9a8 ("drm/armada: move colorkey properties into overlay plane state")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/a4d779d954a7515ddbbf31cb0f0d8184c0e7c879.1689600265.git.geert+renesas@glider.be
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/armada/armada_overlay.c