]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
mptcp: avoid dup SUB_CLOSED events after disconnect
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Tue, 27 Jan 2026 19:27:23 +0000 (20:27 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Jan 2026 04:58:50 +0000 (20:58 -0800)
commit280d654324e33f8e6e3641f76764694c7b64c5db
tree76ec0842385cdbb91a0149dfb8ebf6c9cb077e5d
parent95f82b2b39ef5d9cedf0d87a6a1a4c51146672d6
mptcp: avoid dup SUB_CLOSED events after disconnect

In case of subflow disconnect(), which can also happen with the first
subflow in case of errors like timeout or reset, mptcp_subflow_ctx_reset
will reset most fields from the mptcp_subflow_context structure,
including close_event_done. Then, when another subflow is closed, yet
another SUB_CLOSED event for the disconnected initial subflow is sent.
Because of the previous reset, there are no source address and
destination port.

A solution is then to also check the subflow's local id: it shouldn't be
negative anyway.

Another solution would be not to reset subflow->close_event_done at
disconnect time, but when reused. But then, probably the whole reset
could be done when being reused. Let's not change this logic, similar
to TCP with tcp_disconnect().

Fixes: d82809b6c5f2 ("mptcp: avoid duplicated SUB_CLOSED events")
Cc: stable@vger.kernel.org
Reported-by: Marco Angaroni <marco.angaroni@italtel.com>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/603
Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20260127-net-mptcp-dup-nl-events-v1-1-7f71e1bc4feb@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/protocol.c