]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virDomainDetachDeviceFlags: Clarify update semantics
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 27 Aug 2018 13:40:33 +0000 (15:40 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 4 Sep 2018 08:28:40 +0000 (10:28 +0200)
commit2864b4cd1ccda9c12f0c0ceb340836c42a2a0e52
treecfe23e9d3aa8fcdcf4e3a74d363c9d6703c7566c
parentc04aa383ff9b956b77f288bc7e006fa78a5b21b0
virDomainDetachDeviceFlags: Clarify update semantics

https://bugzilla.redhat.com/show_bug.cgi?id=1621910

When users want to update a path to a CDROM they tend to
construct a very minimal XML and feed the API with it. This is
not a good practice as it breaks the assumptions the API is built
on. Most notably, leaving an element out should be treated as a
request for removal of the corresponding setting. Just like
leaving out <bandwidth/> clears out any QoS previously set.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/libvirt-domain.c