]> git.ipfire.org Git - thirdparty/wireguard-apple.git/commit
NE: Change handling of bad domain names and Activate On Demand
authorRoopesh Chander <roop@roopc.net>
Fri, 21 Dec 2018 10:10:04 +0000 (15:40 +0530)
committerRoopesh Chander <roop@roopc.net>
Fri, 21 Dec 2018 10:22:47 +0000 (15:52 +0530)
commit28ce4d516435306b929aba4a7ccbed00bf16e309
tree3361c59eae9724a48efc506ad2ad92f569606ba8
parentc2131cb75702a5add495894deed5e1ef903cacaf
NE: Change handling of bad domain names and Activate On Demand

The solution implemented in commit b8c331c causes the tunnel to
remain in 'Activating' state, without the ability to cancel that.

So, in this commit, instead of retrying DNS silently on
Activated-On-Demand tunnels, we fail the startTunnel() silently.

To summarize, if activate-on-demand is on:
- If started from the WireGuard app, show error using lastErrorFile
mechanism, suggesting a way to turn off Activate On Demand
- If not started from WireGuard app, don't call displayMessage()
(don't show error to user) and silently fail starting the tunnel

Signed-off-by: Roopesh Chander <roop@roopc.net>
WireGuard/WireGuardNetworkExtension/ErrorNotifier.swift
WireGuard/WireGuardNetworkExtension/PacketTunnelProvider.swift