]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Compare only major versions in AdjustUpgrade.pm
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 24 Jul 2023 15:14:22 +0000 (17:14 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Mon, 24 Jul 2023 15:14:22 +0000 (17:14 +0200)
commit28ce9d51f9082318e84f2a84385871394dcf2130
tree9fab015555f800238af58d82bfcfc33e52445843
parent11237e5a46ca2221aca5c74bf43bb58eff8dcc3b
Compare only major versions in AdjustUpgrade.pm

Because PostgreSQL::Version is very nuanced about development version
numbers, the comparison to 16beta2 makes it think that that release is
older than 16, therefore applying a database tweak that doesn't work
there (the comparison is only supposed to match when run on version 15).
As suggested by Andrew Dunstan, fix by having AdjustUpgrade.pm public
methods create a separate PostgreSQL::Version object to use for these
comparisons, that only carries the major version number.

While at it, have the same methods ensure that the objects given are of
the expected type.

Backpatch to 16.  This module goes all the way back to 9.2, but there's
probably no need for this fix except where betas still live.

Co-authored-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/20230719110504.zbu74o54bqqlsufb@alvherre.pgsql
src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm