]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
bugs/core: Reorganize fields in the first line of WARNING output, add ->comm[] output
authorIngo Molnar <mingo@kernel.org>
Thu, 15 May 2025 12:46:44 +0000 (14:46 +0200)
committerIngo Molnar <mingo@kernel.org>
Mon, 28 Jul 2025 06:06:55 +0000 (08:06 +0200)
commit28ea295f941e39965c562097d5de0e66a373f19d
treea64828b8681efb49ec7c7fdab332e6e6634a51a1
parentbe2ba2fef1676861b295053c2a567b057e9031b9
bugs/core: Reorganize fields in the first line of WARNING output, add ->comm[] output

With the introduction of the condition string as part of the 'file'
string output of kernel warnings, the first line has become a bit
harder to read:

   WARNING: CPU: 0 PID: 0 at [ptr == 0 && 1] kernel/sched/core.c:8511 sched_init+0x20/0x410

Re-order the fields by importance (higher to lower), make the 'at' meaningful
again, and add '->comm[]' output which is often more valuable than a PID.

Also, remove the 'PID' prefix - in combination with comm it's clear what it is.

These changes make the output only slightly longer:

   WARNING: [ptr == 0 && 1] kernel/sched/core.c:8511 at sched_init+0x20/0x410 CPU#0: swapper/0

While adding more information and making it better organized.

Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org> # Rebased ancestor commits
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-arch@vger.kernel.org
Link: https://lore.kernel.org/r/20250515124644.2958810-16-mingo@kernel.org
kernel/panic.c