]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: do not define known no-op features
authorChristian Ehrhardt <christian.ehrhardt@canonical.com>
Thu, 25 Apr 2019 09:04:29 +0000 (11:04 +0200)
committerChristian Ehrhardt <christian.ehrhardt@canonical.com>
Wed, 15 May 2019 07:32:52 +0000 (09:32 +0200)
commit2900575db892700fab8a4b8541474d9bd3444a4a
tree6e76447edf4e8877f01f30f23f87b9c9c9acc16e
parent538d873571d7a682852dc1d70e5f4478f4d64e85
qemu: do not define known no-op features

Qemu dropped cpu features for osxsave and ospke [1][2].
The reason for the instant removal is that those features were never
configurable as discussed in [3].

Fortunately the use cases adding those flags in the past are rare, but
they exist. One that I identified are e.g. older virt-install when used
with --cpu=host-model and there always could be the case of a user
adding it to the guest xml.

This triggers an issue like:
  qemu-system-x86_64: can't apply global Broadwell-noTSX-x86_64-
  cpu.osxsave=on: Property '.osxsave' not found

Ensure that this does no more break spawning newer qemu versions by
not rendering those features into the qemu command line.

Fixes: https://bugs.launchpad.net/fedora/+source/qemu/+bug/1825195
Resolves: https://bugzilla.redhat.com/1644848

[1]: https://git.qemu.org/?p=qemu.git;a=commit;h=f1a2352
[2]: https://git.qemu.org/?p=qemu.git;a=commit;h=9ccb978
[3]: https://www.mail-archive.com/qemu-devel@nongnu.org/msg561877.html

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_command.c
tests/qemuxml2argvdata/cpu-host-model-cmt.args
tests/qemuxml2argvdata/cpu-tsc-frequency.args