]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fbdev: mmp: Fix deferred clk handling in mmphw_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 13 Apr 2023 19:33:17 +0000 (21:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:11:24 +0000 (23:11 +0900)
commit2994b153d6740f8debca5f2b2309f56d79845838
tree4452bb9314a39dab491f135291f0cf955a5c718a
parent1bd40421cbdfaf0e13b5be322eaa144a5655cc80
fbdev: mmp: Fix deferred clk handling in mmphw_probe()

[ Upstream commit b3a7a9ab65ae2f2626c7222fb79cdd433f8c5252 ]

When dev_err_probe() is called, 'ret' holds the value of the previous
successful devm_request_irq() call.
'ret' should be assigned with a meaningful value before being used in
dev_err_probe().

While at it, use and return "PTR_ERR(ctrl->clk)" instead of a hard-coded
"-ENOENT" so that -EPROBE_DEFER is handled and propagated correctly.

Fixes: 81b63420564d ("fbdev: mmp: Make use of the helper function dev_err_probe()")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/fbdev/mmp/hw/mmp_ctrl.c