]> git.ipfire.org Git - people/ms/linux.git/commit
drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow
authorChen Gang <gang.chen@asianux.com>
Thu, 16 May 2013 19:04:25 +0000 (14:04 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 19 May 2013 18:38:44 +0000 (11:38 -0700)
commit29a5fc4815c1ba9365e68927e0c4a267dbba87ca
tree741f04fa4e03d9aa0e91e54bcfc18c15768137f5
parentdce292e9ad1153354e730824f6d90df2c470784d
drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow

commit a5f2b3d6a738e7d4180012fe7b541172f8c8dcea upstream.

When calling memcpy, read_data and write_data need additional 2 bytes.

  write_data:
    for checking:  "if (size > IPMI_MAX_MSG_LENGTH)"
    for operating: "memcpy(bt->write_data + 3, data + 1, size - 1)"

  read_data:
    for checking:  "if (msg_len < 3 || msg_len > IPMI_MAX_MSG_LENGTH)"
    for operating: "memcpy(data + 2, bt->read_data + 4, msg_len - 2)"

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/ipmi/ipmi_bt_sm.c