]> git.ipfire.org Git - thirdparty/libvirt.git/commit
util: reset MAC address of macvtap passthrough physdev after disassociate
authorLaine Stump <laine@laine.org>
Thu, 21 Jan 2016 19:19:56 +0000 (14:19 -0500)
committerLaine Stump <laine@laine.org>
Fri, 22 Jan 2016 18:16:24 +0000 (13:16 -0500)
commit29cc45cb792520c27ff9c55863bf4845dfcb0c97
tree1e542579bb654599807c3dcb3c2127200040b54f
parent81da8bc73b6bc6777632b65a0df45335f7caebe4
util: reset MAC address of macvtap passthrough physdev after disassociate

libvirt always resets the MAC address of the physdev used for macvtap
passthrough when the guest is finished with it. This was happening
prior to the 802.1Qb[gh] DISASSOCIATE command, and was quite often
failing, presumably because the driver wouldn't allow the MAC address
to be reset while the association was still active, with a log message
like this:

virNetDevSetMAC:168 : Cannot set interface MAC to 00:00:00:00:00:00 on 'eth13': Cannot assign requested address

This patch changes the order - we now do the 802.1Qb[gh] disassociate
and delete the macvtap interface first, then and reset the MAC
address.
src/util/virnetdevmacvlan.c