]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
spi: cadence-quadspi: Flush posted register writes before INDAC access
authorPratyush Yadav <pratyush@kernel.org>
Fri, 5 Sep 2025 18:59:55 +0000 (00:29 +0530)
committerMark Brown <broonie@kernel.org>
Tue, 9 Sep 2025 13:17:32 +0000 (14:17 +0100)
commit29e0b471ccbd674d20d4bbddea1a51e7105212c5
tree581242c1ef7af61f912ab08378bc56d7457d526b
parent76eeb9b8de9880ca38696b2fb56ac45ac0a25c6c
spi: cadence-quadspi: Flush posted register writes before INDAC access

cqspi_indirect_read_execute() and cqspi_indirect_write_execute() first
set the enable bit on APB region and then start reading/writing to the
AHB region. On TI K3 SoCs these regions lie on different endpoints. This
means that the order of the two operations is not guaranteed, and they
might be reordered at the interconnect level.

It is possible for the AHB write to be executed before the APB write to
enable the indirect controller, causing the transaction to be invalid
and the write erroring out. Read back the APB region write before
accessing the AHB region to make sure the write got flushed and the race
condition is eliminated.

Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
CC: stable@vger.kernel.org
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
Signed-off-by: Pratyush Yadav <pratyush@kernel.org>
Signed-off-by: Santhosh Kumar K <s-k6@ti.com>
Message-ID: <20250905185958.3575037-2-s-k6@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-quadspi.c