]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cifs: fix integer overflow in match_server()
authorRoman Smirnov <r.smirnov@omp.ru>
Mon, 31 Mar 2025 08:22:49 +0000 (11:22 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 20 Apr 2025 08:15:51 +0000 (10:15 +0200)
commit2a240405978d7a741269d1bf68aee22f3d54e2ba
tree5316ce414af5a045b4d36b40f384c23035b4cccc
parente0717385f5c51e290c2cd2ad4699a778316b5132
cifs: fix integer overflow in match_server()

commit 2510859475d7f46ed7940db0853f3342bf1b65ee upstream.

The echo_interval is not limited in any way during mounting,
which makes it possible to write a large number to it. This can
cause an overflow when multiplying ctx->echo_interval by HZ in
match_server().

Add constraints for echo_interval to smb3_fs_context_parse_param().

Found by Linux Verification Center (linuxtesting.org) with Svace.

Fixes: adfeb3e00e8e1 ("cifs: Make echo interval tunable")
Cc: stable@vger.kernel.org
Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/smb/client/fs_context.c