]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Forbid use of ':' in RBD pool names
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 13 May 2013 12:58:22 +0000 (13:58 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 14 May 2013 14:02:42 +0000 (15:02 +0100)
commit2a2bc1517a7322af7eff07e2854a75bb5f41a10f
treebaae7793277c65c629662128f6dcfc482b1b1c51
parent71b54636f045bbc712e267084d5f1ef7431798b2
Forbid use of ':' in RBD pool names

The QEMU command line syntax for RBD disks is

   file=rbd:pool/image:opt1=val1:opt2=val2...

There is no way to escape the ':' if it appears in the
pool or image name. Thus it must be explicitly forbidden
if it occurs in the libvirt XML. People are known to
be abusing the lack of escaping in current libvirt to
pass arbitrary args to QEMU.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/qemu/qemu_command.c
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-invalid.xml [new file with mode: 0644]
tests/qemuxml2argvtest.c