]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: stmmac: Fix a race in EEE enable callback
authorJose Abreu <jose.abreu@synopsys.com>
Mon, 18 Feb 2019 13:35:03 +0000 (14:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Feb 2019 08:05:59 +0000 (09:05 +0100)
commit2a3c68987c698bf0a12e34fa0e76674ed8cc91c9
treee6db22b06854bc3b80af9cba1daf9de7142aee6d
parent163b06a5fba4282812bea65e37e674dad4c27689
net: stmmac: Fix a race in EEE enable callback

[ Upstream commit 8a7493e58ad688eb23b81e45461c5d314f4402f1 ]

We are saving the status of EEE even before we try to enable it. This
leads to a race with XMIT function that tries to arm EEE timer before we
set it up.

Fix this by only saving the EEE parameters after all operations are
performed with success.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Fixes: d765955d2ae0 ("stmmac: add the Energy Efficient Ethernet support")
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c