]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfs: fix memory leak in error path of nfs4_do_reclaim
authorLi Lingfeng <lilingfeng3@huawei.com>
Wed, 4 Sep 2024 12:34:57 +0000 (20:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:56 +0000 (16:29 +0200)
commit2a4a997adb36b06b49d5664b99bf9ba211a3d784
treedaa5244f36b4e10c9f50b1baf9b569bb1a21416e
parent4d3d0869eccb587ba17c3a7ce61bc617e8aed652
nfs: fix memory leak in error path of nfs4_do_reclaim

commit 8f6a7c9467eaf39da4c14e5474e46190ab3fb529 upstream.

Commit c77e22834ae9 ("NFSv4: Fix a potential sleep while atomic in
nfs4_do_reclaim()") separate out the freeing of the state owners from
nfs4_purge_state_owners() and finish it outside the rcu lock.
However, the error path is omitted. As a result, the state owners in
"freeme" will not be released.
Fix it by adding freeing in the error path.

Fixes: c77e22834ae9 ("NFSv4: Fix a potential sleep while atomic in nfs4_do_reclaim()")
Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>
Cc: stable@vger.kernel.org # v5.3+
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/nfs4state.c