]> git.ipfire.org Git - thirdparty/linux.git/commit
scsi: elx: efct: Fix memory leak in efct_hw_parse_filter()
authorVitaliy Shevtsov <v.shevtsov@mt-integration.ru>
Thu, 12 Jun 2025 16:35:18 +0000 (21:35 +0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 16 Jun 2025 21:52:05 +0000 (17:52 -0400)
commit2a8a5a5dd06eef580f9818567773fd75057cb875
tree67a060ba1b84a881eb143b17803ead20c452b046
parentd8ab68bdb294b09a761e967dad374f2965e1913f
scsi: elx: efct: Fix memory leak in efct_hw_parse_filter()

strsep() modifies the address of the pointer passed to it so that it no
longer points to the original address. This means kfree() gets the wrong
pointer.

Fix this by passing unmodified pointer returned from kstrdup() to
kfree().

Found by Linux Verification Center (linuxtesting.org) with Svace.

Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines")
Signed-off-by: Vitaliy Shevtsov <v.shevtsov@mt-integration.ru>
Link: https://lore.kernel.org/r/20250612163616.24298-1-v.shevtsov@mt-integration.ru
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/elx/efct/efct_hw.c