]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-100221: Fix creating dirs in `make sharedinstall` (GH-100329)
authorMichał Górny <mgorny@gentoo.org>
Wed, 8 Feb 2023 16:50:43 +0000 (17:50 +0100)
committerGitHub <noreply@github.com>
Wed, 8 Feb 2023 16:50:43 +0000 (08:50 -0800)
commit2a8bf2580441147f1a15e61229d669abc0ab86ee
treeb4d819572bb43f6b6020fc8b9405aac153a9e6d4
parent35dd55005ee9aea2843eff7f514ee689a0995df8
gh-100221: Fix creating dirs in `make sharedinstall` (GH-100329)

Fix creating install directories in `make sharedinstall` if they exist already outside `DESTDIR`.  The previous make rules assumed that the directories would be created via a dependency on a rule for `$(DESTSHARED)` that did not fire if the directory did exist outside `$(DESTDIR)`.

While technically `$(DESTDIR)` could be prepended to the rule name, moving the rules for creating directories straight into the `sharedinstall` rule seems to fit the common practices better. Since the rule explicitly checks whether the individual directories exist anyway, there seems to be no reason to rely on make determining that implicitly as well.
Makefile.pre.in
Misc/NEWS.d/next/Build/2022-12-18-08-33-28.gh-issue-100221.K94Ct3.rst [new file with mode: 0644]