]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
memblock, memhotplug: fix wrong type in memblock_find_in_range_node().
authorTang Chen <tangchen@cn.fujitsu.com>
Fri, 29 Aug 2014 22:18:31 +0000 (15:18 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Oct 2014 20:41:03 +0000 (13:41 -0700)
commit2aa79d56e12145039e1de5508a859ac79f20c5dd
tree4512f16fc670538798de981f543228b33bebb7fb
parentdcb67d612aa0b3ec1b72b4aafeb4a8f101cea244
memblock, memhotplug: fix wrong type in memblock_find_in_range_node().

commit 0cfb8f0c3e21e36d4a6e472e4c419d58ba848698 upstream.

In memblock_find_in_range_node(), we defined ret as int.  But it should
be phys_addr_t because it is used to store the return value from
__memblock_find_range_bottom_up().

The bug has not been triggered because when allocating low memory near
the kernel end, the "int ret" won't turn out to be negative.  When we
started to allocate memory on other nodes, and the "int ret" could be
minus.  Then the kernel will panic.

A simple way to reproduce this: comment out the following code in
numa_init(),

        memblock_set_bottom_up(false);

and the kernel won't boot.

Reported-by: Xishi Qiu <qiuxishi@huawei.com>
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Tested-by: Xishi Qiu <qiuxishi@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/memblock.c