]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
nfc: llcp: add missing return after LLCP_CLOSED checks
authorJunxi Qian <qjx1298677004@gmail.com>
Wed, 8 Apr 2026 08:10:06 +0000 (16:10 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sun, 12 Apr 2026 18:12:44 +0000 (11:12 -0700)
commit2b5dd4632966c39da6ba74dbc8689b309065e82c
tree8966f30188eeb49b06925422e74f89b883b66129
parentf462dca0c8415bf0058d0ffa476354c4476d0f09
nfc: llcp: add missing return after LLCP_CLOSED checks

In nfc_llcp_recv_hdlc() and nfc_llcp_recv_disc(), when the socket
state is LLCP_CLOSED, the code correctly calls release_sock() and
nfc_llcp_sock_put() but fails to return. Execution falls through to
the remainder of the function, which calls release_sock() and
nfc_llcp_sock_put() again. This results in a double release_sock()
and a refcount underflow via double nfc_llcp_sock_put(), leading to
a use-after-free.

Add the missing return statements after the LLCP_CLOSED branches
in both functions to prevent the fall-through.

Fixes: d646960f7986 ("NFC: Initial LLCP support")
Signed-off-by: Junxi Qian <qjx1298677004@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20260408081006.3723-1-qjx1298677004@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/nfc/llcp_core.c