]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
QueuePool: support subsecond timeout
authorJordan Pittier <jordan@gorgias.io>
Wed, 18 Nov 2020 14:57:43 +0000 (09:57 -0500)
committerGord Thompson <gord@gordthompson.com>
Sat, 21 Nov 2020 13:47:11 +0000 (06:47 -0700)
commit2b746211188642333b3151bfbb429b236a1559d1
tree21c2591d4ea5d50c630bc1dd638a4eba069384b3
parent17bdc3066c8e5803fdfce6c40f6f04c291e9851d
QueuePool: support subsecond timeout

Fixes: #5719
<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description
Make it explicit in the documentation and in the default value for the 'timeout'
parameter that `timeout` can be a float. Because Python timing is not
very accurate, warn about the precision.

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [ ] A documentation / typographical error fix
- Good to go, no issue or tests are needed
- [x] A short code fix
- please include the issue number, and create an issue if none exists, which
  must include a complete example of the issue.  one line code fixes without an
  issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
  include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.

**Have a nice day!**

Closes: #5710
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5710
Pull-request-sha: 5f4eef8b4aba756d32e14ea41f71ef2919c26b84

Change-Id: I462524b1624ca5cc76d083a1d58e5dc89501c1a9
doc/build/changelog/unreleased_14/5719.rst [new file with mode: 0644]
lib/sqlalchemy/engine/create.py
lib/sqlalchemy/pool/impl.py
test/engine/test_pool.py