]> git.ipfire.org Git - thirdparty/git.git/commit
bisect: fix leaking commit list items in `check_merge_base()`
authorPatrick Steinhardt <ps@pks.im>
Wed, 20 Nov 2024 13:39:35 +0000 (14:39 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 20 Nov 2024 23:23:41 +0000 (08:23 +0900)
commit2b7706aae5b76653bdcb0787a5276a9a53460037
tree1921a5a1ae481f9f0d9dcdaf0765b1e57c7759a0
parentcfb8a0da55fec9619e4e5b1e9b211ef85e3c9cb3
bisect: fix leaking commit list items in `check_merge_base()`

While we free the result commit list at the end of `check_merge_base()`,
we forget to free any items that we have already iterated over. Fix this
by using a separate variable to iterate through them.

This leak is exposed by t6030, but plugging it does not make the whole
test suite pass.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
bisect.c