]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vfs: fix readahead(2) on block devices
authorReuben Hawkins <reubenhwk@gmail.com>
Tue, 3 Oct 2023 01:57:04 +0000 (20:57 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:08:13 +0000 (11:08 +0100)
commit2bb46b20825da0d85ed19bef8538c291354483be
tree9ed629fd54b22e7a760542674de04d9616a68f69
parent20195f87db1920146f75a33dbfb5ffd66bedf534
vfs: fix readahead(2) on block devices

[ Upstream commit 7116c0af4b8414b2f19fdb366eea213cbd9d91c2 ]

Readahead was factored to call generic_fadvise.  That refactor added an
S_ISREG restriction which broke readahead on block devices.

In addition to S_ISREG, this change checks S_ISBLK to fix block device
readahead.  There is no change in behavior with any file type besides block
devices in this change.

Fixes: 3d8f7615319b ("vfs: implement readahead(2) using POSIX_FADV_WILLNEED")
Signed-off-by: Reuben Hawkins <reubenhwk@gmail.com>
Link: https://lore.kernel.org/r/20231003015704.2415-1-reubenhwk@gmail.com
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
mm/readahead.c