]> git.ipfire.org Git - thirdparty/open-vm-tools.git/commit
Fixes for few leaks and improved error handling.
authorOliver Kurth <okurth@vmware.com>
Wed, 8 May 2019 22:27:18 +0000 (15:27 -0700)
committerOliver Kurth <okurth@vmware.com>
Wed, 8 May 2019 22:27:18 +0000 (15:27 -0700)
commit2bbd56da4314856dfc1a8fed2db5b55cd9ef8860
tree98959b4e169497773950b627ee20e0682a8540de
parent544cf1363c78d1d8c75e57d560b3650b5f667c64
Fixes for few leaks and improved error handling.

Fix a memory leak detected by coverity scan. It is not critical,
but it is real in an error case when there is no end mark. While
fixing it, also enhanced code to handle different error cases
properly because we would want valid content to be decoded even
when there are invalid marks in the log file. Invalid log marks
are possible when vmware.log gets rotated in the middle of guest
logging.

While verifying the fix using valgrind, found a couple of more
leaks in panic and warning stubs. Addressed those as well.
open-vm-tools/lib/stubs/stub-panic.c
open-vm-tools/lib/stubs/stub-warning.c
open-vm-tools/xferlogs/xferlogs.c