]> git.ipfire.org Git - thirdparty/qemu.git/commit
i386/cpu: Drop incorrect comment for CPUID 0x1D
authorZhao Liu <zhao1.liu@intel.com>
Tue, 18 Nov 2025 08:08:36 +0000 (16:08 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 27 Dec 2025 09:11:11 +0000 (10:11 +0100)
commit2bc19a54499abe16726e7e8a4e8db839ecd8d060
treef3fe03481840a6af1ed814d52f261d1e1a355bbb
parente8bb12c3507d2f4df2174957c9d288892ebd80c6
i386/cpu: Drop incorrect comment for CPUID 0x1D

The information in CPUID 0x1D.0x1 is for tile palette 1, and is not
SPR-specific.

This is to say, these "hardcoded" values won't change in future. If
the palette needs to be extended, a new tile palette (maybe in a new
subleaf) will be introduced instead of changing current information of
tile palette 1.

Furthermore, the previous attempt [*] to make the 0x1D.0x1 fields
user-configurable is incorrect and unnecessary.

Therefore, drop the incorrect and misleading comment.

[*]: https://lore.kernel.org/qemu-devel/20230106083826.5384-2-lei4.wang@intel.com/

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
Link: https://lore.kernel.org/r/20251118080837.837505-2-zhao1.liu@intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target/i386/cpu.c