]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix determination of broken LSN in OVERWRITTEN_CONTRECORD
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 26 Nov 2021 14:14:27 +0000 (11:14 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 26 Nov 2021 14:14:27 +0000 (11:14 -0300)
commit2c3fddcbbd8aa542beec8e3abf3369168517174e
treec6921cfad304e0ca0200a9180bd445b2d146956c
parenta83b1bab0bdb341f952fc982899be70284c11bdc
Fix determination of broken LSN in OVERWRITTEN_CONTRECORD

In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of
the first record in a page, when the previous record ends exactly at the
page boundary.  The correct LSN is adjusted to skip the WAL page header;
I failed to use that when setting XLogReaderState->overwrittenRecPtr,
so at WAL replay time VerifyOverwriteContrecord would refuse to let
replay continue past that record.

Backpatch to 10.  9.6 also contains this bug, but it's no longer being
maintained.

Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us
src/backend/access/transam/xlogreader.c