]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
llc: fix SAP refcount leak when creating incoming sockets
authorXuanqiang Luo <luoxuanqiang@kylinos.cn>
Sun, 12 Jul 2026 13:03:43 +0000 (21:03 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Fri, 17 Jul 2026 11:17:46 +0000 (13:17 +0200)
commit2c72eb6286347d05a885412fb076993bd5286b53
treefb703bb95a7b88c76f7758507af41d9afad5e90b
parent04aeddf2dadd0eb7ad016a766dcbe9c983311f09
llc: fix SAP refcount leak when creating incoming sockets

llc_sap_add_socket() takes a SAP reference for each socket added to a SAP,
and llc_sap_remove_socket() releases it. llc_create_incoming_sock() takes
an additional SAP reference after adding the child socket.

This extra reference was balanced by an explicit llc_sap_put() in
llc_ui_release() until commit 3100aa9d74db ("llc: fix SAP reference
counting w.r.t. socket handling") removed that put. The corresponding hold
in the accept path was left behind.

When such a child socket is removed, only the reference taken by
llc_sap_add_socket() is released. The extra reference keeps the SAP alive
after its last socket is removed. Remove the obsolete hold.

Fixes: 3100aa9d74db ("llc: fix SAP reference counting w.r.t. socket handling")
Cc: stable@vger.kernel.org
Signed-off-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Link: https://patch.msgid.link/20260712130343.518797-1-xuanqiang.luo@linux.dev
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/llc/llc_conn.c