]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc()
authorJackie Liu <liuyun01@kylinos.cn>
Wed, 1 Sep 2021 12:35:57 +0000 (20:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:58:40 +0000 (11:58 +0100)
commit2c96cb6fbf2c7955b12c913592a2e4ced53d9dbc
tree257d9821db22dfe9efa7d8259b2c42f44c229e34
parent5401e8894f3f4806c700343e50ae305e413be495
ARM: s3c: irq-s3c24xx: Fix return value check for s3c24xx_init_intc()

[ Upstream commit 2aa717473ce96c93ae43a5dc8c23cedc8ce7dd9f ]

The s3c24xx_init_intc() returns an error pointer upon failure, not NULL.
let's add an error pointer check in s3c24xx_handle_irq.

s3c_intc[0] is not NULL or ERR, we can simplify the code.

Fixes: 1f629b7a3ced ("ARM: S3C24XX: transform irq handling into a declarative form")
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
Link: https://lore.kernel.org/r/20210901123557.1043953-1-liu.yun@linux.dev
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-s3c24xx.c