]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: axis-fifo: Correct handling of tx_fifo_depth for size validation
authorGabriel Shahrouzi <gshahrouzi@gmail.com>
Sat, 19 Apr 2025 01:29:37 +0000 (21:29 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 14:14:15 +0000 (16:14 +0200)
commit2ca34b508774aaa590fc3698a54204706ecca4ba
treeee4d292c86ee454d7dd7859c73d8aa04397d5e10
parent98698ca0e58734bc5c1c24e5bbc7429f981cd186
staging: axis-fifo: Correct handling of tx_fifo_depth for size validation

Remove erroneous subtraction of 4 from the total FIFO depth read from
device tree. The stored depth is for checking against total capacity,
not initial vacancy. This prevented writes near the FIFO's full size.

The check performed just before data transfer, which uses live reads of
the TDFV register to determine current vacancy, correctly handles the
initial Depth - 4 hardware state and subsequent FIFO fullness.

Fixes: 4a965c5f89de ("staging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core")
Cc: stable@vger.kernel.org
Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com>
Link: https://lore.kernel.org/r/20250419012937.674924-1-gshahrouzi@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/axis-fifo/axis-fifo.c