]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Provide more detailed error message for Query.join()
authorRamonWill <ramonwilliams@hotmail.co.uk>
Thu, 6 Aug 2020 20:08:13 +0000 (16:08 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Mon, 31 Aug 2020 22:27:48 +0000 (18:27 -0400)
commit2cc963dbdc4fc4e0bd2c0bb7cdecdcc84ac8f629
treef8ce956fdaa5570d1efca5b89ac9bab1d5555748
parent0a234fee4bed27036f7d75b659b6a2ed0512efe6
Provide more detailed error message for Query.join()

An :class:`.ArgumentError` with more detail is now raised if the target
parameter for :meth:`_query.Query.join` is set to an unmapped object.
Prior to this change a less detailed ``AttributeError`` was raised.
Pull request courtesy Ramon Williams.

Fixes: #4428
Closes: #5452
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/5452
Pull-request-sha: b148df547037e9a254fe331eff8e922c78426261

Change-Id: I873453d1fdb651178216aac698baac63ae5a94e8
doc/build/changelog/unreleased_13/4428.rst [new file with mode: 0644]
lib/sqlalchemy/orm/query.py
test/orm/test_joins.py