]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fbdev: Add bounds checking in bit_putcs to fix vmalloc-out-of-bounds
authorAlbin Babu Varghese <albinbabuvarghese20@gmail.com>
Fri, 3 Oct 2025 07:32:09 +0000 (03:32 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Nov 2025 20:37:38 +0000 (15:37 -0500)
commit2d1359e11674ed4274934eac8a71877ae5ae7bbb
tree82bb5572b7a3894b74c1287820c7abe78ccf876c
parent3cc8161f91bab4e26ca44cfcbcb14a079c8de4be
fbdev: Add bounds checking in bit_putcs to fix vmalloc-out-of-bounds

[ Upstream commit 3637d34b35b287ab830e66048841ace404382b67 ]

Add bounds checking to prevent writes past framebuffer boundaries when
rendering text near screen edges. Return early if the Y position is off-screen
and clip image height to screen boundary. Break from the rendering loop if the
X position is off-screen. When clipping image width to fit the screen, update
the character count to match the clipped width to prevent buffer size
mismatches.

Without the character count update, bit_putcs_aligned and bit_putcs_unaligned
receive mismatched parameters where the buffer is allocated for the clipped
width but cnt reflects the original larger count, causing out-of-bounds writes.

Reported-by: syzbot+48b0652a95834717f190@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=48b0652a95834717f190
Suggested-by: Helge Deller <deller@gmx.de>
Tested-by: syzbot+48b0652a95834717f190@syzkaller.appspotmail.com
Signed-off-by: Albin Babu Varghese <albinbabuvarghese20@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/fbdev/core/bitblit.c