]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/sched: memset() 'job' in drm_sched_job_init()
authorPhilipp Stanner <pstanner@redhat.com>
Mon, 21 Oct 2024 10:50:28 +0000 (12:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 19:03:50 +0000 (20:03 +0100)
commit2da108b4b5fb7ec04d7e951418ed80e97f7c35ad
tree228e2bed05e770904ef26e946b67c95be4ae09e0
parent3e75b36733dde251ca3c488b7dd8bae79a92e18e
drm/sched: memset() 'job' in drm_sched_job_init()

[ Upstream commit 2320c9e6a768d135c7b0039995182bb1a4e4fd22 ]

drm_sched_job_init() has no control over how users allocate struct
drm_sched_job. Unfortunately, the function can also not set some struct
members such as job->sched.

This could theoretically lead to UB by users dereferencing the struct's
pointer members too early.

It is easier to debug such issues if these pointers are initialized to
NULL, so dereferencing them causes a NULL pointer exception.
Accordingly, drm_sched_entity_init() does precisely that and initializes
its struct with memset().

Initialize parameter "job" to 0 in drm_sched_job_init().

Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241021105028.19794-2-pstanner@redhat.com
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/scheduler/sched_main.c