]> git.ipfire.org Git - thirdparty/openvpn.git/commit
proxy.c refactoring: remove always-NULL gc parameter
authorGert Doering <gert@greenie.muc.de>
Fri, 9 Jun 2017 20:50:29 +0000 (22:50 +0200)
committerGert Doering <gert@greenie.muc.de>
Mon, 12 Jun 2017 06:24:43 +0000 (08:24 +0200)
commit2dca268a643d4cfe375ef46950b57ef660073711
tree9700447626d717ad55e7b8563df589b5e0a16b34
parente5b236eaba4512f86da917a0a63dd0f84e1b02db
proxy.c refactoring: remove always-NULL gc parameter

get_proxy_authenticate() is called with a "gc" parameter which MUST
be NULL, otherwise string_alloc() will allocate memory in the gc_arena
while the caller expects the result to be durable and will do explicit
free() when no longer needed.  Remove gc parameter, call string_alloc()
with "NULL" so this is clearly visible.

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Steffan Karger <steffan.karger@fox-it.com>
Message-Id: <20170609205029.11002-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14768.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/proxy.c