]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dm: always update the array size in realloc_argv on success
authorBenjamin Marzinski <bmarzins@redhat.com>
Tue, 15 Apr 2025 04:17:16 +0000 (00:17 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 May 2025 07:41:35 +0000 (09:41 +0200)
commit2dd94484415dde4da0f5c40ff2809d9ef4a01935
tree58b3fc9e35e16fa6cebf447febf2685a5a8c5af7
parent12351db6c325ec74160ea176ca0b7b7ae678633f
dm: always update the array size in realloc_argv on success

commit 5a2a6c428190f945c5cbf5791f72dbea83e97f66 upstream.

realloc_argv() was only updating the array size if it was called with
old_argv already allocated. The first time it was called to create an
argv array, it would allocate the array but return the array size as
zero. dm_split_args() would think that it couldn't store any arguments
in the array and would call realloc_argv() again, causing it to
reallocate the initial slots (this time using GPF_KERNEL) and finally
return a size. Aside from being wasteful, this could cause deadlocks on
targets that need to process messages without starting new IO. Instead,
realloc_argv should always update the allocated array size on success.

Fixes: a0651926553c ("dm table: don't copy from a NULL pointer in realloc_argv()")
Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm-table.c