]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iscsi-target: Avoid early conn_logout_comp for iser connections
authorNicholas Bellinger <nab@linux-iscsi.org>
Mon, 23 Feb 2015 08:57:51 +0000 (00:57 -0800)
committerJiri Slaby <jslaby@suse.cz>
Thu, 9 Apr 2015 11:14:20 +0000 (13:14 +0200)
commit2ddc09fbd0e4fc6dec0b24c7e1978043a67933e1
tree28bbff4c068abfa2302208c2ff3924a05e860834
parent033acbf6a597707356691d0621c1496bc5a610b1
iscsi-target: Avoid early conn_logout_comp for iser connections

commit f068fbc82e7696d67b1bb8189306865bedf368b6 upstream.

This patch fixes a iser specific logout bug where early complete()
of conn->conn_logout_comp in iscsit_close_connection() was causing
isert_wait4logout() to complete too soon, triggering a use after
free NULL pointer dereference of iscsi_conn memory.

The complete() was originally added for traditional iscsi-target
when a ISCSI_LOGOUT_OP failed in iscsi_target_rx_opcode(), but given
iser-target does not wait in logout failure, this special case needs
to be avoided.

Reported-by: Sagi Grimberg <sagig@mellanox.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Cc: Slava Shwartsman <valyushash@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/target/iscsi/iscsi_target.c