]> git.ipfire.org Git - thirdparty/asterisk.git/commit
chan_dahdi: Don't retry opening nonexistent channels on restart.
authorNaveen Albert <asterisk@phreaknet.org>
Tue, 26 Mar 2024 11:43:32 +0000 (07:43 -0400)
committerasterisk-org-access-app[bot] <120671045+asterisk-org-access-app[bot]@users.noreply.github.com>
Wed, 27 Mar 2024 15:03:52 +0000 (15:03 +0000)
commit2de1a683392d94b98734a90a2d818b92f505712d
tree66f883ea4f2e7f582e72cec242537e5ef4a578c8
parent4ebef70763f306ece203c9d3537af8777fc51668
chan_dahdi: Don't retry opening nonexistent channels on restart.

Commit 729cb1d390b136ccc696430aa5c68d60ea4028be added logic to retry
opening DAHDI channels on "dahdi restart" if they failed initially,
up to 1,000 times in a loop, to address cases where the channel was
still in use. However, this retry loop does not use the actual error,
which means chan_dahdi will also retry opening nonexistent channels
1,000 times per channel, causing a flood of unnecessary warning logs
for an operation that will never succeed, with tens or hundreds of
thousands of open attempts being made.

The original patch would have been more targeted if it only retried
on the specific relevant error (likely EBUSY, although it's hard to
say since the original issue is no longer available).

To avoid the problem above while avoiding the possibility of breakage,
this skips the retry logic if the error is ENXIO (No such device or
address), since this will never succeed.

Resolves: #669
channels/chan_dahdi.c