]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUILD: http_fetch: silence an uninitiialized warning with gcc-4/5/6 at -Os
authorWilly Tarreau <w@1wt.eu>
Tue, 4 Oct 2022 07:18:34 +0000 (09:18 +0200)
committerWilly Tarreau <w@1wt.eu>
Tue, 4 Oct 2022 07:18:34 +0000 (09:18 +0200)
commit2e2b79d157944d12922ae7ad487247259f3e6d70
tree6532d41313c5ad77881e927680d6600189057b92
parenteefcd8a97de7d1b05b38d240b1061e2f2112f2f8
BUILD: http_fetch: silence an uninitiialized warning with gcc-4/5/6 at -Os

Gcc 4.x, 5.x and 6.x report this when compiling http_fetch.c:

  src/http_fetch.c: In function 'smp_fetch_meth':
  src/http_fetch.c:357:6: warning: 'htx' may be used uninitialized in this function [-Wmaybe-uninitialized]
     sl = http_get_stline(htx);

That's quite weird since there's no such code path, but presetting the
htx variable to NULL during declaration is enough to shut it up.

This may be backported to any version that has dbbdb25f1 ("BUG/MINOR:
http-fetch: Use integer value when possible in "method" sample fetch")
as it's the one that triggered this warning (hence at least 2.0).
src/http_fetch.c