]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pkt_sched: fix virtual-start-time update in QFQ
authorPaolo Valente <paolo.valente@unimore.it>
Sat, 15 Sep 2012 00:41:35 +0000 (00:41 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Oct 2012 20:47:01 +0000 (05:47 +0900)
commit2e300638e5e3530f3f67ba33d8cfeb9864d395a9
tree6e6de08c1f5958783eaa9194511aad228258f5f8
parent061c476429681ff17d5fa2079eb6f4fc5229748c
pkt_sched: fix virtual-start-time update in QFQ

[ Upstream commit 71261956973ba9e0637848a5adb4a5819b4bae83 ]

If the old timestamps of a class, say cl, are stale when the class
becomes active, then QFQ may assign to cl a much higher start time
than the maximum value allowed. This may happen when QFQ assigns to
the start time of cl the finish time of a group whose classes are
characterized by a higher value of the ratio
max_class_pkt/weight_of_the_class with respect to that of
cl. Inserting a class with a too high start time into the bucket list
corrupts the data structure and may eventually lead to crashes.
This patch limits the maximum start time assigned to a class.

Signed-off-by: Paolo Valente <paolo.valente@unimore.it>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sched/sch_qfq.c