]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fs: replace mmap hook with .mmap_prepare for simple mappings
authorLorenzo Stoakes <lorenzo.stoakes@oracle.com>
Mon, 16 Jun 2025 19:33:29 +0000 (20:33 +0100)
committerChristian Brauner <brauner@kernel.org>
Thu, 19 Jun 2025 11:56:59 +0000 (13:56 +0200)
commit2e3b37a7e48f8a52fb708cdbeec9d8af0a5af0c1
treeeec595c44d10093de12131c3cac5a0480382501a
parent9d5403b1036cdcd4be0f9f5568612c0e60e73d79
fs: replace mmap hook with .mmap_prepare for simple mappings

Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file
callback"), the f_op->mmap() hook has been deprecated in favour of
f_op->mmap_prepare().

This callback is invoked in the mmap() logic far earlier, so error handling
can be performed more safely without complicated and bug-prone state
unwinding required should an error arise.

This hook also avoids passing a pointer to a not-yet-correctly-established
VMA avoiding any issues with referencing this data structure.

It rather provides a pointer to the new struct vm_area_desc descriptor type
which contains all required state and allows easy setting of required
parameters without any consideration needing to be paid to locking or
reference counts.

Note that nested filesystems like overlayfs are compatible with an
.mmap_prepare() callback since commit bb666b7c2707 ("mm: add mmap_prepare()
compatibility layer for nested file systems").

In this patch we apply this change to file systems with relatively simple
mmap() hook logic - exfat, ceph, f2fs, bcachefs, zonefs, btrfs, ocfs2,
orangefs, nilfs2, romfs, ramfs and aio.

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Link: https://lore.kernel.org/f528ac4f35b9378931bd800920fee53fc0c5c74d.1750099179.git.lorenzo.stoakes@oracle.com
Acked-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
16 files changed:
fs/aio.c
fs/bcachefs/fs.c
fs/btrfs/file.c
fs/ceph/addr.c
fs/ceph/file.c
fs/ceph/super.h
fs/exfat/file.c
fs/f2fs/file.c
fs/nilfs2/file.c
fs/ocfs2/file.c
fs/ocfs2/mmap.c
fs/ocfs2/mmap.h
fs/orangefs/file.c
fs/ramfs/file-nommu.c
fs/romfs/mmap-nommu.c
fs/zonefs/file.c