]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: dvbdev: fix the logic when DVB_DYNAMIC_MINORS is not set
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 6 Nov 2024 20:50:55 +0000 (21:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:47:39 +0000 (19:47 +0100)
commit2e7ce4e50d146006357a110c60bb8cdebb73c0b5
treebae4a131b3f3ab58cc93d9d87056928d3b484d5b
parentc29a44d9a4024a87de51db5fc5ed2a5999f7340b
media: dvbdev: fix the logic when DVB_DYNAMIC_MINORS is not set

commit a4aebaf6e6efff548b01a3dc49b4b9074751c15b upstream.

When CONFIG_DVB_DYNAMIC_MINORS, ret is not initialized, and a
semaphore is left at the wrong state, in case of errors.

Make the code simpler and avoid mistakes by having just one error
check logic used weather DVB_DYNAMIC_MINORS is used or not.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202410201717.ULWWdJv8-lkp@intel.com/
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/9e067488d8935b8cf00959764a1fa5de85d65725.1730926254.git.mchehab+huawei@kernel.org
Cc: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/dvb-core/dvbdev.c