]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
selinux: handle TCP SYN-ACK packets correctly in selinux_ip_postroute()
authorPaul Moore <pmoore@redhat.com>
Wed, 4 Dec 2013 21:10:51 +0000 (16:10 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Dec 2013 15:34:20 +0000 (07:34 -0800)
commit2ea04e5a3d579032632c72584ea67b623321064c
treeea2d1ac04a2559bc55aa2dde512e99d9e8f16862
parent1c5d9d1527ceb57e66001fba3d84c766d89baf2e
selinux: handle TCP SYN-ACK packets correctly in selinux_ip_postroute()

commit 446b802437f285de68ffb8d6fac3c44c3cab5b04 upstream.

In selinux_ip_postroute() we perform access checks based on the
packet's security label.  For locally generated traffic we get the
packet's security label from the associated socket; this works in all
cases except for TCP SYN-ACK packets.  In the case of SYN-ACK packet's
the correct security label is stored in the connection's request_sock,
not the server's socket.  Unfortunately, at the point in time when
selinux_ip_postroute() is called we can't query the request_sock
directly, we need to recreate the label using the same logic that
originally labeled the associated request_sock.

See the inline comments for more explanation.

Reported-by: Janak Desai <Janak.Desai@gtri.gatech.edu>
Tested-by: Janak Desai <Janak.Desai@gtri.gatech.edu>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/selinux/hooks.c