]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
mptcp: schedule rtx timer only after pushing data
authorPaolo Abeni <pabeni@redhat.com>
Fri, 5 Dec 2025 18:55:16 +0000 (19:55 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Dec 2025 07:54:03 +0000 (23:54 -0800)
commit2ea6190f42d0416a4310e60a7fcb0b49fcbbd4fb
tree78b39b0043b2dc05b7db9d20951024e207feae50
parent29f4801e9c8dfd12bdcb33b61a6ac479c7162bd7
mptcp: schedule rtx timer only after pushing data

The MPTCP protocol usually schedule the retransmission timer only
when there is some chances for such retransmissions to happen.

With a notable exception: __mptcp_push_pending() currently schedule
such timer unconditionally, potentially leading to unnecessary rtx
timer expiration.

The issue is present since the blamed commit below but become easily
reproducible after commit 27b0e701d387 ("mptcp: drop bogus optimization
in __mptcp_check_push()")

Fixes: 33d41c9cd74c ("mptcp: more accurate timeout")
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20251205-net-mptcp-misc-fixes-6-19-rc1-v1-3-9e4781a6c1b8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/protocol.c