]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm: rcar-du: Fix memory leak in rcar_du_vsps_init()
authorBiju Das <biju.das.jz@bp.renesas.com>
Thu, 16 Nov 2023 12:24:24 +0000 (12:24 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:07:08 +0000 (11:07 +0100)
commit2ea6be36a389b80b01b1887710981758c433e3b9
tree3c772b94bbbcd219ca0b0076196ecefba90e0d0a
parentfda0cb6f845e7c535797a968e3e8f9fd42b4fa5e
drm: rcar-du: Fix memory leak in rcar_du_vsps_init()

[ Upstream commit 91e3bf09a90bb4340c0c3c51396e7531555efda4 ]

The rcar_du_vsps_init() doesn't free the np allocated by
of_parse_phandle_with_fixed_args() for the non-error case.

Fix memory leak for the non-error case.

While at it, replace the label 'error'->'done' as it applies to non-error
case as well and update the error check condition for rcar_du_vsp_init()
to avoid breakage in future, if it returns positive value.

Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same VSP")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Link: https://lore.kernel.org/r/20231116122424.80136-1-biju.das.jz@bp.renesas.com
Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/rcar-du/rcar_du_kms.c