]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
remoteproc: avoid stack overflow in debugfs file
authorArnd Bergmann <arnd@arndb.de>
Fri, 20 Nov 2015 17:26:07 +0000 (18:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Feb 2016 22:22:37 +0000 (14:22 -0800)
commit2ed0426bd1fd55d115787cbdb7c381f4c907a8e5
treea32c0f994e4687e288a3dfdd34d7ca090e8e11e1
parente9828fd09906acf8fedb6152f58ec97b24d671e2
remoteproc: avoid stack overflow in debugfs file

commit 92792e48e2ae6051af30468a87994b5432da2f06 upstream.

Recent gcc versions warn about reading from a negative offset of
an on-stack array:

drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]

I don't see anything in sys_write() that prevents us from
being called with a zero 'count' argument, so we should
add an extra check in rproc_recovery_write() to prevent the
access and avoid the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2e37abb89a2e ("remoteproc: create a 'recovery' debugfs entry")
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/remoteproc/remoteproc_debugfs.c