]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
USB: usbfs: compute urb->actual_length for isochronous
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 8 Nov 2017 17:23:17 +0000 (12:23 -0500)
committerSasha Levin <alexander.levin@verizon.com>
Thu, 7 Dec 2017 02:20:13 +0000 (21:20 -0500)
commit2ef0c44f3f6852b1df9c2ba1ce126fbac66c4259
treecaab4195944d89fe150d57467a472c0307e03baf
parent78fad35aab599a6651e4fadb4fdb6e5099571a7a
USB: usbfs: compute urb->actual_length for isochronous

[ Upstream commit 2ef47001b3ee3ded579b7532ebdcf8680e4d8c54 ]

The USB kerneldoc says that the actual_length field "is read in
non-iso completion functions", but the usbfs driver uses it for all
URB types in processcompl().  Since not all of the host controller
drivers set actual_length for isochronous URBs, programs using usbfs
with some host controllers don't work properly.  For example, Minas
reports that a USB camera controlled by libusb doesn't work properly
with a dwc2 controller.

It doesn't seem worthwhile to change the HCDs and the documentation,
since the in-kernel USB class drivers evidently don't rely on
actual_length for isochronous transfers.  The easiest solution is for
usbfs to calculate the actual_length value for itself, by adding up
the lengths of the individual packets in an isochronous transfer.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Reported-and-tested-by: wlf <wulf@rock-chips.com>
CC: <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/usb/core/devio.c