]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nbd: make the config put is called before the notifying the waiter
authorXiubo Li <xiubli@redhat.com>
Wed, 14 Oct 2020 02:45:14 +0000 (22:45 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Nov 2020 10:08:45 +0000 (11:08 +0100)
commit2ef6f4bd60411934e3fc2715442c2afe70f84bf3
treeaa3b51d8b8ea3eca4c7b4cf236fd4e5c41d0209f
parentc151f68411cdeac5d70b48a19758d20ab110e4cc
nbd: make the config put is called before the notifying the waiter

[ Upstream commit 87aac3a80af5cbad93e63250e8a1e19095ba0d30 ]

There has one race case for ceph's rbd-nbd tool. When do mapping
it may fail with EBUSY from ioctl(nbd, NBD_DO_IT), but actually
the nbd device has already unmaped.

It dues to if just after the wake_up(), the recv_work() is scheduled
out and defers calling the nbd_config_put(), though the map process
has exited the "nbd->recv_task" is not cleared.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/block/nbd.c