]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
serial: 8250_bcm2835aux: Fix clock imbalance in PM resume
authorStefan Wahren <wahrenst@gmx.net>
Sun, 18 Aug 2024 17:49:36 +0000 (19:49 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Sep 2024 08:47:42 +0000 (10:47 +0200)
commit2f102a5efe84808768a57ac2a5f1884bd56d62d8
treefbfcde75e07900bf0609a3f194018a93ba27db27
parentd2e8590fd1048c5c0dba160edc6a48ee8305a1f0
serial: 8250_bcm2835aux: Fix clock imbalance in PM resume

During review Ulf Hansson discovered a clock imbalance in the recently
introduced PM resume code. The driver should enable the clock only in
case it has been disabled in suspend before. In order to make the
conditions easier to read, refactor this into a separate function.

Reported-by: Ulf Hansson <ulf.hansson@linaro.org>
Closes: https://lore.kernel.org/linux-arm-kernel/CAPDyKFoJh3j8xSeXZ9o031YZLTCDYVA+dgvURuwozjDpU_aauA@mail.gmail.com/
Fixes: 0e1d8780526f ("serial: 8250_bcm2835aux: add PM suspend/resume support")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20240818174936.88372-1-wahrenst@gmx.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_bcm2835aux.c