]> git.ipfire.org Git - thirdparty/apache/httpd.git/commit
Here's the patch that really sucks. old_listeners points to an array
authorWilliam A. Rowe Jr <wrowe@apache.org>
Wed, 20 Mar 2002 07:03:07 +0000 (07:03 +0000)
committerWilliam A. Rowe Jr <wrowe@apache.org>
Wed, 20 Mar 2002 07:03:07 +0000 (07:03 +0000)
commit2f1fdebb2d7b574095bc217521afc7481d4a1384
tree4603ec28a5eb237b01b33b7a681dfb69948e6eb9
parent20cd5bdb74b01da1469e4634f72cc9301437dbf8
  Here's the patch that really sucks.  old_listeners points to an array
  of apr_socket objects already destroyed by their cleanups, and in any
  case they now live in invalid memory.  Extend their lifetimes.

  This implies that the process pool grows on every restart for no good
  reason.  One possible solution is to let the old pconf survive until
  the new pconf is alive.  Another is to create the listeners in a subpool
  of process->pool, destroyed after the old_listeners are closed.

  Either which way, a better solution exists, but this closes the immediate
  bug.  [How haven't we been segfaulting in unix on restarts before this
  patch, gurus?]

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@94048 13f79535-47bb-0310-9956-ffa450edef68
server/listen.c