]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
selftests: drv-net: tso: don't touch dangerous feature bits
authorJakub Kicinski <kuba@kernel.org>
Mon, 29 Jun 2026 23:39:23 +0000 (16:39 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 1 Jul 2026 00:23:25 +0000 (17:23 -0700)
commit2f7f2e311106cb838d3f3fb6ef25effdb3f8e366
tree8f0a03625a89a66fc24c56eb992157984ddf4ace
parent5d6dc22d62682d93f5f55f145ad792f2891de911
selftests: drv-net: tso: don't touch dangerous feature bits

query_nic_features() detects which offloads depend on tx-gso-partial
by enabling everything, turning tx-gso-partial off, and seeing which
active features drop out. Enabling all hw features is dangerous:
we may end up enabling rx-fcs and loopback for example. For the
ice driver we end up getting into problems with feature dependencies
so the cleanup isn't successful either, and the test exits with
rx-fcs and loopback enabled.

Scope the feature probing just to segmentation bits.

Fixes: 266b835e5e84 ("selftests: drv-net: tso: enable test cases based on hw_features")
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Reviewed-by: Daniel Zahka <daniel.zahka@gmail.com>
Link: https://patch.msgid.link/20260629233923.2151144-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/drivers/net/hw/tso.py