]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
hwmon: sy7636a: Fix regulator_enable resource leak on error path
authorHaotian Zhang <vulab@iscas.ac.cn>
Wed, 26 Nov 2025 16:26:02 +0000 (00:26 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 26 Nov 2025 17:03:15 +0000 (09:03 -0800)
commit2f88425ef590b7fcc2324334b342e048edc144a9
tree13480f2a8c06a797b01b017e1d29c2c021f6ff6c
parenta4d01f3b02d0afb5e4497a1ec5d48da2a326d468
hwmon: sy7636a: Fix regulator_enable resource leak on error path

In sy7636a_sensor_probe(), regulator_enable() is called but if
devm_hwmon_device_register_with_info() fails, the function returns
without calling regulator_disable(), leaving the regulator enabled
and leaking the reference count.

Switch to devm_regulator_get_enable() to automatically
manage the regulator resource.

Fixes: de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a")
Suggested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20251126162602.2086-1-vulab@iscas.ac.cn
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/sy7636a-hwmon.c